[New] no-string-refs: allow this.refs in > 18.3.0
#3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 27, 2024
henryqdineen
force-pushed
the
hqd-this-dot-refs
branch
from
f59b3fa to
5f8e578
Compare
ljharb
approved these changes
Aug 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3807 +/- ##
==========================================
+ Coverage 97.49% 97.76% +0.27%
==========================================
Files 132 135 +3
Lines 9707 9721 +14
Branches 3554 3554
==========================================
+ Hits 9464 9504 +40
+ Misses 243 217 -26 ☔ View full report in Codecov by Sentry. |
ljharb
force-pushed
the
hqd-this-dot-refs
branch
from
5f8e578 to
c48cb1f
Compare
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React version 18.3.0 they released a change to support writing to
this.refs. In the React 19 RC Upgrade Guide they suggest running a codemod that will remove the string ref usage but still usethis.refs, which can cause false positives for theno-string-refsrule.My PR simply tests the React version before checking the
MemberExpression. Thanks!